GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46541: Generate the global objects initializer. by ericsnowcurrently · Pull Request #30941 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jan 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This change is a prerequisite for generating code for other global objects (like strings in gh-30928).

(I borrowed some code from Tools/scripts/deepfreeze.py.)

https://bugs.python.org/issue46541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction
ericsnowcurrently added 2 commits January 26, 2022 18:21
@ericsnowcurrently
Generate part of the runtime initializer.
a4a5304
@ericsnowcurrently
Add "make regen-global-objects".
0110ac6
@ericsnowcurrently ericsnowcurrently added the skip news label Jan 27, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 27, 2022
@pxeger

pxeger commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

This should probably be documented in the devguide
olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently

ericsnowcurrently commented Jan 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

This should probably be documented in the devguide

Yeah, we should definitely add some documentation there about the various code generation tools we use:

  • argument clinic
  • blurb
  • freeze_modules.py
  • deepfreeze.py
  • ...

Consider opening a BPO issue so this doesn't get lost. Feel free to nosy me.
olife-png reacted with thumbs up emoji olife-png reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
ericsnowcurrently merged commit 247480a into python:main Jan 27, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jan 27, 2022
@ericsnowcurrently
ericsnowcurrently deleted the global-objects-generated-code branch January 27, 2022 18:06
@pxeger pxeger mentioned this pull request Jan 27, 2022
Document the various code generation tools used by CPython python/devguide#805
Closed
@pxeger

pxeger commented Jan 27, 2022

Copy link
Copy Markdown
Contributor

I opened python/devguide#805. Note that Argument Clinic is already at https://docs.python.org/3/howto/clinic.html and blurb is at https://devguide.python.org/committing/?highlight=blurb#updating-news-and-what-s-new-in-python
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @pxeger @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.