GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46556: emit `DeprecationWarning` from `pathlib.Path.__enter__()` by barneygale · Pull Request #30971 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Jan 27, 2022 •
edited by brettcannon
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In Python 3.9, Path.__exit__() was made a no-op.

https://bugs.python.org/issue46556

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
bpo-46556: emit DeprecationWarning from pathlib.Path.__enter__()
c53f031 
In Python 3.9 / bpo-39682 we made `Path.__exit__()` a no-op, and added a
comment in the code mentioning that it should be deprecated in future. The
future is here, so let's deprecate it.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 27, 2022
@bedevere-bot bedevere-bot added the awaiting review label Jan 27, 2022
sobolevn
sobolevn reviewed Jan 28, 2022
View reviewed changes
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
Test that using a path as a context manager raises DeprecationWarning
6bf4483
@brettcannon
brettcannon self-requested a review January 28, 2022 18:26
@barneygale
Tweak comment in __enter__()
6e086f8
tirkarthi
tirkarthi reviewed Jan 30, 2022
View reviewed changes

@tirkarthi tirkarthi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are deprecation warnings emitted by other tests too :

./python -Wall -m test test_pathlib         
0:00:00 load avg: 0.37 Run tests sequentially
0:00:00 load avg: 0.37 [1/1] test_pathlib
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1833: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:
/home/karthikeyan/stuff/python/cpython/Lib/test/test_pathlib.py:1842: DeprecationWarning: pathlib.Path.__enter__() is deprecated and scheduled for removal in Python 3.13. Path objects should not be used as context managers.
  with p:

== Tests result: SUCCESS ==

1 test OK.

Total duration: 586 ms
Tests result: SUCCESS

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@barneygale
Fix up warning from test.
8ae3459
brettcannon
brettcannon approved these changes Feb 4, 2022
View reviewed changes
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 4, 2022
@brettcannon
Tweak warning message
87c9067
brettcannon
brettcannon reviewed Feb 4, 2022
View reviewed changes
Comment thread Lib/pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
Tweak warning message
e150f96
@brettcannon brettcannon closed this Feb 5, 2022
@brettcannon brettcannon reopened this Feb 5, 2022
@brettcannon brettcannon self-assigned this Feb 5, 2022
@brettcannon brettcannon added the 🤖 automerge label Feb 5, 2022
@brettcannon

brettcannon commented Feb 5, 2022

Copy link
Copy Markdown
Member

I'm ready to merge this, but there was a CI hiccup; just trying to work passed that.
barneygale reacted with thumbs up emoji barneygale reacted with hooray emoji
All reactions
  • 👍 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 5, 2022

Copy link
Copy Markdown
Contributor

@barneygale: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon closed this Feb 8, 2022
@brettcannon brettcannon reopened this Feb 8, 2022
@miss-islington

miss-islington commented Feb 8, 2022

Copy link
Copy Markdown
Contributor

@barneygale: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon
brettcannon merged commit 06e1701 into python:main Feb 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 8, 2022
@brettcannon

brettcannon commented Feb 8, 2022

Copy link
Copy Markdown
Member

@barneygale thanks!
barneygale reacted with thumbs up emoji barneygale reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale mannequin mentioned this pull request Apr 10, 2022
pathlib.Path objects can be used as context managers #83863
Closed
@barneygale barneygale mannequin mentioned this pull request Oct 3, 2023
pathlib.Path.__enter__() should emit DeprecationWarning #90714
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@tirkarthi tirkarthi tirkarthi left review comments
@sobolevn sobolevn sobolevn left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@barneygale @brettcannon @miss-islington @tirkarthi @sobolevn @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.