GeezerVison is showing github.com — bpo-46553: allow bare typing.ClassVar annotations by GBeauregard · Pull Request #30983 · python/cpython
Conversation
GBeauregard
commented
Jan 28, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This is a simple matter of just adding ClassVar to the list of types allowed to be bare before the later call that raises for bare types.
These are used in the wild and covered by dataclasses unit tests.
Several static type checkers support this pattern.
Note we adjust one test from ClassVar[ClassVar] to
ClassVar[ClassVar[int]] so that it still fails. This is surprising, but
not a result of weirdness we're doing in this patch. This is a
limitation of the current way runtime type checking works that this case
is allowed when bare special forms are allowed. For example, before this
patch ClassVar[Final] is a valid runtime annotation despite nesting these
forms being generally disallowed, so it's expected allowing bare ClassVar
makes ClassVar[ClassVar] valid as well.
https://bugs.python.org/issue46553
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
These are used in the wild and covered by dataclasses unit tests.
Several static type checkers support this pattern.
Note we adjust one test from ClassVar[ClassVar] to
ClassVar[ClassVar[int]] so that it still fails. This is surprising, but
not a result of weirdness we're doing in this patch. This is a
limitation of the current way runtime type checking works that this case
is allowed when bare special forms are allowed. For example, before this
patch `ClassVar[Final]` is a valid annotation despite nesting these
forms being generally disallowed. Addressing this limitation could be
future work.
GBeauregard
changed the title
typing: allow bare ClassVar annotations
bpo-46553: allow bare typing.ClassVar annotations
Jan 28, 2022
|
@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.