GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45953: Preserve backward compatibility on some PyThreadState field names. by ericsnowcurrently · Pull Request #31038 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jan 31, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The gevent project is using the two PyThreadState fields I renamed in gh-30590. This PR fixes the names. See https://bugs.python.org/issue45953#msg412046.

https://bugs.python.org/issue45953

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Preserve backward compatibility on some PyThreadState field names.
a4f2f68
@ericsnowcurrently ericsnowcurrently added the skip news label Jan 31, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 31, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jan 31, 2022
@ericsnowcurrently
ericsnowcurrently requested a review from brandtbucher January 31, 2022 19:55
brandtbucher
brandtbucher approved these changes Feb 1, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 1, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Feb 1, 2022
@miss-islington
miss-islington merged commit f78be59 into python:main Feb 1, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 1, 2022
@ericsnowcurrently
ericsnowcurrently deleted the fix-gevent-threadstate branch February 1, 2022 17:02
@brandtbucher brandtbucher mentioned this pull request Feb 1, 2022
Compatibility with Python3.11 (again) python-greenlet/greenlet#288
Closed
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 8, 2022
Statically allocate interpreter states as much as possible. #90111
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ericsnowcurrently @brandtbucher @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.