GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-98410: move getbufferproc and releasebufferproc to buffer.h by davidhewitt · Pull Request #31158 · python/cpython Conversation
|
|
Closing as the buffer protocol is available in 3.11 in Limited C API. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@kumaraditya303 can I please push for you to consider reopening and reviewing this patch? The point that the buffer protocol is available in 3.11 is exactly why I think this should be merged. As of current 3.11 release on the limited API I can call (And equivalent for |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@davidhewitt Sorry for closing your PR. I reopened it and you are correct that the function typedefs are not exposed. I would suggest you to create issue for this issue to discuss this first, nobody looked at this because no issue was mentioned and there are conflicts and and this can't be fixed in 3.11 as the rc is out and final is about to be released. There are conflicts in this PR, I would suggest you create a new PR with fixed conflicts but it's your choice if you want to continue with this one. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@kumaraditya303 thanks very much - I have opened #98410 and I'm happy to spend the time to rebase this PR once someone has suggested that a change of this nature would potentially be suitable to merge. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for the catch! Let me know if you want more info, or if you'd prefer to leave this to me. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks - I'll do my best to find a moment to tidy this up tonight! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
7c6bb60 to
a11ce47
Compare
|
@encukou how does that look? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
75b0e16 to
eae6de2
Compare
eae6de2 to
a768db1
Compare
|
rebased |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Looks good, thank you! but with typedefs, we can relax this rule a little: they'll be available to people building for 3.11 using 3.12. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.