GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — bpo-46586: Fix documentation links by meersuri · Pull Request #31216 · python/cpython

Conversation

meersuri commented Feb 8, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Incorrectly pointed to built-in the property() function as mentioned in #46586

https://bugs.python.org/issue46586

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Fix enum.property documentation link

a7dd04a

Incorrectly pointed to built-in the property() function as mentioned in python#46586

meersuri requested a review from ethanfurman as a code owner

February 8, 2022 15:30

the-knights-who-say-ni added the CLA not signed label

Feb 8, 2022

the-knights-who-say-ni commented Feb 8, 2022

Copy link

Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@meersuri

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting review docs Documentation in the Doc dir labels

Feb 8, 2022

the-knights-who-say-ni added CLA signed and removed CLA not signed labels

Feb 8, 2022

JelleZijlstra added the skip news label

Feb 8, 2022

blurb-it Bot and others added 2 commits

February 8, 2022 15:38


          📜🤖 Added by blurb_it.

64f5b1d


          Fix links to builtin max, min in sys.float_info

078b226

ethanfurman changed the title ~~bpo-46586: Fix enum.property documentation link~~ bpo-46586: Fix documentation links

Feb 10, 2022

JelleZijlstra reviewed

Feb 10, 2022

View reviewed changes

Comment thread

Doc/library/sys.rst Outdated

		\| \| \| digits in the significand of a float \|
		+---------------------+----------------+--------------------------------------------------+
		\| :const:`max` \| DBL_MAX \| maximum representable positive finite float \|
		\| :const:`!max` \| DBL_MAX \| maximum representable positive finite float \|

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better done in a separate PR, so we can backport to the other bugfix branches.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zware and AlexWaygood reacted with thumbs up emoji

All reactions

👍 2 reactions

meersuri Feb 10, 2022

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, so I guess that will require opening another issue and then the corresponding PR? Should I revert this commit here then?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, revert the commit here. It doesn't need an issue; trivial docs fixes don't need an issue. You can just attach the second PR to the same issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, based on @zware's comment on the bug, it's going to be better to change these to just put max in double backticks, since they aren't supposed to link anywhere.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

zware Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That comment was @merwok, not me 😉. I agree with him, though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Misc/NEWS.d/next/Documentation/2022-02-08-15-38-16.bpo-46586.6qVFVL.rst Outdated

		@@ -0,0 +1 @@
		Fix enum.property link to point to the enum page rather than the built-in property() page No newline at end of file

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this needs a NEWS entry at all.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zware and AlexWaygood reacted with thumbs up emoji

All reactions

👍 2 reactions

meersuri Feb 10, 2022

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah sorry about that, I used blurb-it for the first time and by the time I was done, I saw that the skip-news label had been added. Should I just make another commit to remove this file?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Feb 10, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Revert "📜🤖 Added by blurb_it."

47d95ac

This reverts commit 64f5b1d.

JelleZijlstra approved these changes

Feb 12, 2022

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels

Feb 12, 2022

zware approved these changes

Feb 12, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels

Feb 12, 2022

ethanfurman approved these changes

Feb 12, 2022

View reviewed changes

ethanfurman merged commit 9d9cfd6 into python:main

Feb 12, 2022

bedevere-bot removed the awaiting merge label

Feb 12, 2022

Dutcho mannequin mentioned this pull request

Apr 10, 2022

In documentation same-named attributes erroneously link to built-in names #90744

Closed

Reviewers

JelleZijlstra

JelleZijlstra approved these changes

zware

zware approved these changes

ethanfurman

ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

meersuri commented Feb 8, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

the-knights-who-say-ni commented Feb 8, 2022

Recognized GitHub username

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

meersuri commented Feb 8, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.