GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix sphinx-lint after #31097 and b878b3a by sobolevn · Pull Request #31248 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 10, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

main branch is failing, see https://dev.azure.com/python/cpython/_build/results?buildId=96616&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171

Logs:

PATH=./venv/bin:$PATH sphinx-lint -i tools -i ./venv -i README.rst
No problems found.
PATH=./venv/bin:$PATH sphinx-lint ../Misc/NEWS.d/next/
[1] ../Misc/NEWS.d/next/Library/2022-02-09-00-53-23.[bpo-45863](https://bugs.python.org/issue45863).zqQXVv.rst:0: No newline at end of file (no-newline-at-end-of-file).
[1] ../Misc/NEWS.d/next/Build/2022-01-19-11-08-32.[bpo-46430](https://bugs.python.org/issue46430).k403m_.rst:0: No newline at end of file (no-newline-at-end-of-file).
2 problems with severity 1 found.

This PR fixes these two problems, so main is green again.

Related PR: #31097
CC @JulienPalard

Automerge-Triggered-By: GH:JulienPalard

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
Fix sphinx-lint after python#31097 and b878b3a
1419399
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 10, 2022
@bedevere-bot bedevere-bot added the awaiting review label Feb 10, 2022
@sobolevn sobolevn added skip issue skip news labels Feb 10, 2022
@sobolevn
sobolevn requested a review from JulienPalard February 10, 2022 08:52
@JulienPalard

JulienPalard commented Feb 10, 2022

Copy link
Copy Markdown
Member

Oops I should have rebased right before merging this one, I'm looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JulienPalard
JulienPalard approved these changes Feb 10, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 10, 2022
@JulienPalard JulienPalard added the 🤖 automerge label Feb 10, 2022
@JulienPalard

JulienPalard commented Feb 10, 2022

Copy link
Copy Markdown
Member

Thanks @sobolevn for the fast PR :)
sobolevn reacted with hooray emoji sobolevn reacted with rocket emoji
All reactions
  • 🎉 1 reaction
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

@sobolevn: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit dee020a into python:main Feb 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 10, 2022
@vstinner

vstinner commented Feb 10, 2022

Copy link
Copy Markdown
Member

I backported the tarfile change to 3.9 and 3.10, do these branches also need a fix? https://bugs.python.org/issue45863
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Feb 10, 2022

Copy link
Copy Markdown
Member

main branch is failing, see https://dev.azure.com/python/cpython/_build/results?buildId=96616&view=logs&j=4db1505a-29e5-5cc0-240b-53a8a2681f75&t=a975920c-8356-5388-147c-613d5fab0171

I didn't notice the failure on the PR #29693

Is it because the branch is old (Nov 2021) and was not rebased before being merged? Maybe the strict CI tests were added later?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

Is it because the branch is old (Nov 2021) and was not rebased before being merged? Maybe the strict CI tests were added later?

Yes, looks like this is the case.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JulienPalard

JulienPalard commented Feb 10, 2022

Copy link
Copy Markdown
Member

do these branches also need a fix?

I did not backported sphinx-lint to old branch and I don't want to, rstlint does an OK job on those branche, sphinx-lint is very new, main is enough for me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JulienPalard JulienPalard JulienPalard approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @JulienPalard @miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.