GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46333: include `module` in `ForwardRef.__repr__` by aha79 · Pull Request #31283 · python/cpython

Conversation

@aha79

@aha79 aha79 commented Feb 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The module parameter carries semantic information about the forward ref.
Show to the user that forward refs with same argument but different
module are different.

This is the split-off part from GH-30536 which should not be backported.

https://bugs.python.org/issue46333

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@andreas-h-sie
bpo-46333: include module in ForwardRef.__repr__ if it is set.
e039dbc 
The module parameter carries semantic information about the forward ref.
Show to the user that forward refs with same argument but different
module are different.
@aha79
aha79 requested review from Fidget-Spinner and gvanrossum as code owners February 11, 2022 19:59
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2022
@blurb-it
📜🤖 Added by blurb_it.
a1cbd5f
@JelleZijlstra
JelleZijlstra self-requested a review February 11, 2022 20:24
@andreas-h-sie
remove trailing whitespace
63b37eb
JelleZijlstra
JelleZijlstra approved these changes Feb 12, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 12, 2022
AlexWaygood
AlexWaygood approved these changes Feb 12, 2022
View reviewed changes
@AlexWaygood AlexWaygood added the type-feature A feature request or enhancement label Feb 12, 2022
gvanrossum
gvanrossum approved these changes Feb 12, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 12, 2022
@gvanrossum
gvanrossum merged commit b70690b into python:main Feb 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 12, 2022
@bedevere-bot

bedevere-bot commented Feb 12, 2022

Copy link
Copy Markdown

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aha79
aha79 deleted the bpo-46333_include_module_in_forward_ref_repr branch February 13, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@aha79 @bedevere-bot @JelleZijlstra @gvanrossum @AlexWaygood @the-knights-who-say-ni @andreas-h-sie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.