GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-46615: Don't crash when set operations mutate the sets (GH-31120) by miss-islington · Pull Request #31284 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Ensure strong references are acquired whenever using set_next(). Added randomized test cases for __eq__ methods that sometimes mutate sets when called.
(cherry picked from commit 4a66615)

Co-authored-by: Dennis Sweeney [email protected]

https://bugs.python.org/issue46615

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sweeneyde @miss-islington
bpo-46615: Don't crash when set operations mutate the sets (pythonGH-…
dde3b3e 
…31120)

Ensure strong references are acquired whenever using `set_next()`. Added randomized test cases for `__eq__` methods that sometimes mutate sets when called.
(cherry picked from commit 4a66615)

Co-authored-by: Dennis Sweeney <[email protected]>
@miss-islington
miss-islington requested a review from rhettinger as a code owner February 11, 2022 20:09
@bedevere-bot bedevere-bot added the awaiting review label Feb 11, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 11, 2022
@miss-islington

miss-islington commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

@sweeneyde: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Feb 11, 2022
bpo-46615: Don't crash when set operations mutate the sets #31120
Merged
@miss-islington

miss-islington commented Feb 11, 2022

Copy link
Copy Markdown
Contributor Author

@sweeneyde: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Feb 11, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Feb 11, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 11, 2022
@miss-islington
miss-islington merged commit 1f5fe99 into python:3.10 Feb 11, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 11, 2022
@miss-islington
miss-islington deleted the backport-4a66615-3.10 branch February 11, 2022 20:44
@sweeneyde sweeneyde mentioned this pull request May 18, 2022
Use-after-free by mutating set during set operations #90773
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @sweeneyde
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.