GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46541: Discover the global strings. by ericsnowcurrently · Pull Request #31346 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Feb 14, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Instead of manually enumerating the global strings in generate_global_objects.py, we extrapolate the list from usage of _Py_ID() and _Py_STR() in the source files.

This is partly inspired by gh-31261.

https://bugs.python.org/issue46541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits February 14, 2022 16:11
@ericsnowcurrently
Discover the identifiers.
8481178
@ericsnowcurrently
Match multiple per line.
9d3e430
@ericsnowcurrently
Discover the non-identifier strings too.
4443d89
@ericsnowcurrently
ericsnowcurrently requested review from iritkatriel, isidentical and markshannon as code owners February 14, 2022 23:49
@bedevere-bot bedevere-bot added the awaiting core review label Feb 14, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 14, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Feb 14, 2022
bpo-46712: Share global string identifiers in deepfreeze #31261
Merged
@ericsnowcurrently ericsnowcurrently added the skip news label Feb 14, 2022
@ericsnowcurrently
ericsnowcurrently removed request for iritkatriel, isidentical and markshannon February 15, 2022 00:00
@ericsnowcurrently
ericsnowcurrently merged commit 12360aa into python:main Feb 15, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 15, 2022
@ericsnowcurrently
ericsnowcurrently deleted the global-objects-discover-identifiers branch February 15, 2022 00:36
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.