GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34526：[doc] Add description and examples of multiple arguments for Path.relative_to by lvluling · Pull Request #31368 · python/cpython

Conversation

@lvluling

@lvluling lvluling commented Feb 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

the docs for Path.relative_to is a bit confusing why other is a star-args, especially as no example actually passes more than one argument to relative_to

https://bugs.python.org/issue34526

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lvluling
add description and examples of multiple arguments for Path.relative_…
de0f8ce 
…to()
@bedevere-bot bedevere-bot added the awaiting review label Feb 16, 2022
@the-knights-who-say-ni

the-knights-who-say-ni commented Feb 16, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@lvluling

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Feb 16, 2022
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 16, 2022
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Feb 18, 2022
CharlieZhao95
CharlieZhao95 reviewed Feb 24, 2022
View reviewed changes
Comment thread Doc/library/pathlib.rst
*other*. If it's impossible, ValueError is raised::
Return the relative path to another path identified by *other*, each
element of *other* can be either a string representing a path segment,
or another path object implementing the :class:`PurePath`(or a subclass

@CharlieZhao95 CharlieZhao95 Feb 21, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. You missed the definition of class PurePath in the context, it could be changed from :class:PurePath to the class PurePath.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra

JelleZijlstra commented May 2, 2022

Copy link
Copy Markdown
Member

@barneygale would you be able to review this PR?
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label May 2, 2022
@anntzer anntzer mannequin mentioned this pull request May 2, 2022
Path.relative_to() taking multiple arguments could be better documented #78707
Closed
@barneygale

barneygale commented May 2, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I've left a comment on the #78707. I don't think relative_to() and is_relative_to() should accept multiple arguments - I'd rather we restricted this to methods that explicitly deal with path construction - PurePath() and PurePath.joinpath().
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@hauntsaninja hauntsaninja added the topic-pathlib label Jan 7, 2023
@barneygale

barneygale commented Jan 14, 2023

Copy link
Copy Markdown
Contributor

In #94469 we deprecated passing multiple positional arguments to relative_to(), so I think this patch is no longer valid. Thank you for working on it all the same!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale barneygale closed this Jan 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@CharlieZhao95 CharlieZhao95 CharlieZhao95 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review docs Documentation in the Doc dir skip news topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

9 participants

@lvluling @the-knights-who-say-ni @JelleZijlstra @barneygale @CharlieZhao95 @hauntsaninja @ezio-melotti @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.