GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-46333: Honor `module` parameter in ForwardRef (GH-30536) by miss-islington · Pull Request #31379 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The module parameter carries semantic information about the forward ref.
Forward refs are different if they refer to different module even if they
have the same name. This affects the __eq__, __repr__ and __hash__ methods.

Co-authored-by: Andreas Hangauer [email protected]
Co-authored-by: Alex Waygood [email protected]
Co-authored-by: Ken Jin [email protected]
(cherry picked from commit 6e7b813)

Co-authored-by: aha79 [email protected]

https://bugs.python.org/issue46333

Automerge-Triggered-By: GH:JelleZijlstra

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aha79 @miss-islington
bpo-46333: Honor module parameter in ForwardRef (pythonGH-30536)
c1898ee 
The `module` parameter carries semantic information about the forward ref.
Forward refs are different if they refer to different module even if they
have the same name. This affects the `__eq__`, `__repr__` and `__hash__` methods.

Co-authored-by: Andreas Hangauer <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Ken Jin <[email protected]>
(cherry picked from commit 6e7b813)

Co-authored-by: aha79 <[email protected]>
@miss-islington
miss-islington requested review from Fidget-Spinner and gvanrossum as code owners February 17, 2022 03:28
@bedevere-bot bedevere-bot added the awaiting review label Feb 17, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 17, 2022
@bedevere-bot bedevere-bot mentioned this pull request Feb 17, 2022
bpo-46333: Honor module parameter in ForwardRef #30536
Merged
@miss-islington

miss-islington commented Feb 17, 2022

Copy link
Copy Markdown
Contributor Author

@aha79 and @JelleZijlstra: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Feb 17, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 17, 2022
@JelleZijlstra JelleZijlstra added the 🤖 automerge label Feb 17, 2022
@miss-islington

miss-islington commented Feb 17, 2022

Copy link
Copy Markdown
Contributor Author

@miss-islington: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit a17d59a into python:3.10 Feb 17, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 17, 2022
@miss-islington
miss-islington deleted the backport-6e7b813-3.10 branch February 17, 2022 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum gvanrossum is a code owner
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @JelleZijlstra @the-knights-who-say-ni @bedevere-bot @aha79
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.