GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46066: catch DeprecationWarning by JelleZijlstra · Pull Request #31428 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Feb 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46066

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
bpo-46066: catch DeprecationWarning
9370e19
@JelleZijlstra
JelleZijlstra requested review from Fidget-Spinner and gvanrossum as code owners February 19, 2022 06:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 19, 2022
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Feb 19, 2022
@JelleZijlstra JelleZijlstra added the skip news label Feb 19, 2022
sobolevn
sobolevn reviewed Feb 19, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
97littleleaf11
97littleleaf11 reviewed Feb 19, 2022
View reviewed changes

@97littleleaf11 97littleleaf11 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry that I missed the warnings. Thanks @tirkarthi for pointing out!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra commented Feb 19, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Update Lib/test/test_typing.py
a0de625
@JelleZijlstra
JelleZijlstra requested a review from sobolevn February 19, 2022 15:58
sobolevn
sobolevn approved these changes Feb 19, 2022
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@JelleZijlstra

JelleZijlstra commented Feb 19, 2022

Copy link
Copy Markdown
Member Author

@gvanrossum Planning to merge this simple PR (fixes an oversight in the TD kwargs deprecation change; approved by Nikita).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Feb 19, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’d rephrase the commit message using “Check deprecation warning”.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 19, 2022
@AlexWaygood AlexWaygood mentioned this pull request Feb 19, 2022
bpo-46801: suppress deprecation warnings in test_typing #31433
Closed
@JelleZijlstra
JelleZijlstra merged commit 0a8a8e7 into python:main Feb 20, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 20, 2022
@JelleZijlstra
JelleZijlstra deleted the tddepr branch February 20, 2022 01:44
@97littleleaf11 97littleleaf11 mannequin mentioned this pull request Dec 22, 2022
Deprecate keyword args syntax for TypedDict definition #90224
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@sobolevn sobolevn sobolevn approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
+1 more reviewer
@97littleleaf11 97littleleaf11 97littleleaf11 left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JelleZijlstra @gvanrossum @sobolevn @97littleleaf11 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.