GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec by corona10 · Pull Request #31475 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-45641: Remove usage of _Py_IDENTIFIER from multibytecodec
94bcfa7
@corona10
corona10 requested a review from vstinner February 21, 2022 15:42
@bedevere-bot bedevere-bot added the awaiting core review label Feb 21, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 21, 2022
@corona10 corona10 added the skip news label Feb 21, 2022
@corona10
corona10 requested a review from erlend-aasland February 21, 2022 15:46
erlend-aasland
erlend-aasland reviewed Feb 21, 2022
View reviewed changes
Comment thread Modules/cjkcodecs/multibytecodec.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Feb 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In the issue number, 65 was transposed as 56. Fixed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy changed the title bpo-45641: Remove usage of _Py_IDENTIFIER from multibytecodec bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec Feb 21, 2022
@corona10
bpo-46541: Address code review
f5e1200
erlend-aasland
erlend-aasland approved these changes Feb 22, 2022
View reviewed changes
kumaraditya303
kumaraditya303 approved these changes Feb 26, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10 corona10 mentioned this pull request Feb 26, 2022
bpo-46541: remove usage of _Py_IDENTIFIER from _ssl module #31599
Merged
tiran
tiran suggested changes Feb 27, 2022
View reviewed changes
Comment thread Modules/cjkcodecs/multibytecodec.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Feb 27, 2022
@bedevere-bot

bedevere-bot commented Feb 27, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Feb 27, 2022
@corona10
bpo-46541: Address code review
bc21a19
@corona10

corona10 commented Feb 28, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Feb 28, 2022
@bedevere-bot

bedevere-bot commented Feb 28, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from tiran February 28, 2022 09:08
@corona10

corona10 commented Mar 1, 2022

Copy link
Copy Markdown
Member Author

After some discussion, I decided to merge this PR anyway.
I will accept the other approach if someone wants :) I hope that this approach would help to reduce the usage of private APIs
cc @ericsnowcurrently, @erlend-aasland, @tiran, @vstinner (alphabetical order :)
erlend-aasland, ericsnowcurrently, and kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 merged commit 0cc6364 into python:main Mar 1, 2022
@bedevere-bot bedevere-bot removed the awaiting change review label Mar 1, 2022
@corona10
corona10 deleted the bpo-46541-multibytecodec branch March 1, 2022 14:35
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@vstinner vstinner Awaiting requested review from vstinner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@corona10 @terryjreedy @bedevere-bot @tiran @erlend-aasland @kumaraditya303 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.