GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46771: Review tweaks by Tinche · Pull Request #31483 · python/cpython

Conversation

@Tinche

@Tinche Tinche commented Feb 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@asvetlov Minor changes and reverting the cancel counters for a different PR.

https://bugs.python.org/issue46771

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Tinche added 2 commits February 22, 2022 02:04
@Tinche
Rename deadline to when(), clean up type annotations
5f82e16
@Tinche
Revert cancel counters for future PR
e93f5de
@Tinche
Tinche requested review from 1st1 and asvetlov as code owners February 22, 2022 01:13
@bedevere-bot bedevere-bot added the awaiting review label Feb 22, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 22, 2022
@Tinche Tinche mentioned this pull request Feb 22, 2022
bpo-46771: Implement asyncio context managers for handling timeouts #31394
Merged
@asvetlov

asvetlov commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @Tinche
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov
asvetlov merged commit 6fb9cfc into python:issue-46771 Feb 22, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Feb 22, 2022
@bedevere-bot

bedevere-bot commented Feb 22, 2022

Copy link
Copy Markdown

@asvetlov: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov
asvetlov deleted the issue-46771-review-tweaks branch February 22, 2022 10:00
@gvanrossum gvanrossum mentioned this pull request May 24, 2022
Implement asyncio.timeout() context manager #90927
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Tinche @asvetlov @bedevere-bot @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.