GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46771: Implement task cancel requests by Tinche · Pull Request #31508 · python/cpython

Conversation

@Tinche

@Tinche Tinche commented Feb 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46771

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Tinche
Implement task cancel requests
7400ff0
@Tinche
Tinche requested review from 1st1 and asvetlov as code owners February 22, 2022 19:11
@bedevere-bot bedevere-bot added the awaiting review label Feb 22, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 22, 2022
@Tinche Tinche mentioned this pull request Feb 22, 2022
bpo-46771: Implement asyncio context managers for handling timeouts #31394
Merged
@asvetlov

asvetlov commented Feb 22, 2022

Copy link
Copy Markdown
Contributor

Not sure if python:issue-46771 is the best base branch.
Maybe this PR should be made against main?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Tinche

Tinche commented Feb 22, 2022

Copy link
Copy Markdown
Contributor Author

@gvanrossum said he would like this merged into issue-46771 first, and then merge that into main, so I'm following this plan.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Feb 22, 2022

Copy link
Copy Markdown
Member

@gvanrossum said he would like this merged into issue-46771 first, and then merge that into main, so I'm following this plan.

I think you misunderstood me. I meant for this to be a PR against main, which would be merged into main before merging the timeout class (presumably the branch with the timeout class would have to merge main in first, after the cancel changes were merged into main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Tinche Tinche closed this Feb 22, 2022
@asvetlov
asvetlov deleted the issue-46771-cancel-requests branch February 22, 2022 23:50
@gvanrossum gvanrossum mentioned this pull request May 24, 2022
Implement asyncio.timeout() context manager #90927
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Tinche @asvetlov @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.