GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46430: fix error-handling in _Py_Deepfreeze_Init by kumaraditya303 · Pull Request #31596 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Feb 26, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes error-handling in interning of strings in deep-frozen modules.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
fix error-handling
1f7a1ff
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner February 26, 2022 07:22
@bedevere-bot bedevere-bot added the awaiting review label Feb 26, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 26, 2022
@kumaraditya303 kumaraditya303 changed the title bpo-46712: fix error-handling in _Py_Deepfreeze_Init bpo-46430: fix error-handling in _Py_Deepfreeze_Init Feb 26, 2022
@kumaraditya303

kumaraditya303 commented Feb 26, 2022

Copy link
Copy Markdown
Contributor Author

cc @vstinner @gvanrossum
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Feb 26, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 26, 2022
@gvanrossum gvanrossum added the skip news label Feb 26, 2022
@gvanrossum
gvanrossum merged commit 0d9b565 into python:main Feb 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 26, 2022
@vstinner

vstinner commented Feb 26, 2022

Copy link
Copy Markdown
Member

Thank you @kumaraditya303! I will help to make Python startup more reliable. It will prevent a crash if Python is started in an environment with very low memory available, or in a sandbox setting an arbitrary memory limit.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the error-handling branch February 28, 2022 07:11
@kumaraditya303 kumaraditya303 mentioned this pull request Apr 10, 2022
Share global string identifiers in deepfreeze #90868
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @vstinner @gvanrossum @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.