GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46541: Remove unnecessary Py_VISIT (GH-31608) by corona10 · Pull Request #31608 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Feb 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
bpo-46541: Remove unnecessary Py_VISIT
747caab
@corona10 corona10 added the skip news label Feb 28, 2022
@corona10
corona10 requested a review from tiran February 28, 2022 02:08
@bedevere-bot bedevere-bot added the awaiting core review label Feb 28, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2022
tiran
tiran approved these changes Feb 28, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Feb 28, 2022
@tiran tiran changed the title bpo-46541: Remove unnecessary Py_VISIT bpo-46541: Remove unnecessary Py_VISIT (GH-31608) Feb 28, 2022
@tiran
tiran merged commit 088dd76 into python:main Feb 28, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 28, 2022
@corona10
corona10 deleted the bpo-46541-visit branch February 28, 2022 07:08
@corona10 corona10 mentioned this pull request Apr 19, 2022
gh-90699: Use module state to access insert str object. #91693
Merged
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@corona10 @tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.