GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46541: Remove unneeded visits from sqlite3 by erlend-aasland · Pull Request #31609 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Feb 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue46541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
bpo-46541: Remove unneeded visits from sqlite3
d09ae9b
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner February 28, 2022 08:17
@bedevere-bot bedevere-bot added the awaiting review label Feb 28, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2022
@erlend-aasland
erlend-aasland force-pushed the sqlite-remove-unneeded-visit branch from 4eb3cc7 to d09ae9b Compare February 28, 2022 08:17
@erlend-aasland
erlend-aasland requested a review from corona10 February 28, 2022 08:18
@erlend-aasland erlend-aasland added the skip news label Feb 28, 2022
corona10
corona10 approved these changes Feb 28, 2022
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 28, 2022
kumaraditya303
kumaraditya303 approved these changes Feb 28, 2022
View reviewed changes
@corona10
corona10 merged commit c32aef4 into python:main Feb 28, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 28, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-remove-unneeded-visit branch February 28, 2022 09:45
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @corona10 @kumaraditya303 @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.