GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-30121: Fix debug assert in subprocess on Windows (#1224) by vstinner · Pull Request #3173 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 21, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • bpo-30121: Fix debug assert in subprocess on Windows (bpo-30121: Fix debug assert in subprocess on Windows #1224)
  • Add test_subprocess.test_nonexisting_with_pipes() (bpo-30121: Write an unit test #3133)

https://bugs.python.org/issue30121

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
segevfiner and others added 2 commits August 21, 2017 23:51
@segevfiner @vstinner
bpo-30121: Fix debug assert in subprocess on Windows (#1224)
a043bf1 
* bpo-30121: Fix debug assert in subprocess on Windows

This is caused by closing HANDLEs using os.close which is for CRT file
descriptors and not for HANDLEs.

* bpo-30121: Suppress debug assertion in test_subprocess when ran directly

(cherry picked from commit 4d38517)
@vstinner
Add test_subprocess.test_nonexisting_with_pipes() (#3133)
d4e183b 
bpo-30121: Test the Popen failure when Popen was created with pipes.
Create also NONEXISTING_CMD variable in test_subprocess.py.
(cherry picked from commit 9a83f65)
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Aug 21, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Aug 21, 2017
@vstinner vstinner mentioned this pull request Aug 21, 2017
[3.6] bpo-30871: Add test.pythoninfo #3174
Merged
@vstinner vstinner added the skip news label Aug 21, 2017
@vstinner
vstinner merged commit e76cb43 into python:3.6 Aug 21, 2017
@vstinner
vstinner deleted the subprocess_handle branch August 21, 2017 22:15
@Mariatta Mariatta removed the awaiting merge label Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @Mariatta @the-knights-who-say-ni @bedevere-bot @segevfiner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.