GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly (GH-29468) by miss-islington · Pull Request #31756 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Mar 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: Marco Ribeiro [email protected]
(cherry picked from commit 36dd739)

Co-authored-by: Ma Lin [email protected]

https://bugs.python.org/issue44439

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@miss-islington
bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly (py…
fa08197 
…thonGH-29468)

Co-authored-by: Marco Ribeiro <[email protected]>
(cherry picked from commit 36dd739)

Co-authored-by: Ma Lin <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Mar 8, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 8, 2022
@bedevere-bot bedevere-bot mentioned this pull request Mar 8, 2022
bpo-44439: _ZipWriteFile.write() handle buffer protocol correctly #29468
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Mar 8, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Mar 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 8, 2022
@miss-islington

miss-islington commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Mar 8, 2022

Copy link
Copy Markdown
Contributor Author

@animalize and @serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 21c5b3f into python:3.10 Mar 8, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 8, 2022
@miss-islington
miss-islington deleted the backport-36dd739-3.10 branch March 8, 2022 10:03
@animalize animalize mannequin mentioned this pull request Apr 12, 2022
stdlib wrongly uses len() for bytes-like object #88605
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.