GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Block more non-working syscalls in Emscripten (GH-31757) by tiran · Pull Request #31757 · python/cpython

Conversation

@tiran

@tiran tiran commented Mar 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • getgroups always fails.
  • geteuid and getegid always return 0 (root), which confuse tarfile and
    tests.
  • hardlinks (link, linkat) always fails.
  • non-encodable file names are not supported by NODERAWFS layer.
  • mark more tests with dependency on subprocess and multiprocessing.
    Mocking does not work if the module fails to import.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@tiran
bpo-40280: Block more non-working syscalls in Emscripten
165341b
- getgroups always fails.
- geteuid and getegid always return 0 (root), which confuse tarfile and
  tests.
- hardlinks (link, linkat) always fails.
- non-encodable file names are not supported by NODERAWFS layer.
- mark more tests with dependency on subprocess and multiprocessing.
  Mocking does not work if the module fails to import.

Signed-off-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot added the awaiting core review label Mar 8, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 8, 2022
@tiran tiran added the skip news label Mar 8, 2022
@tiran tiran changed the title bpo-40280: Block more non-working syscalls in Emscripten bpo-40280: Block more non-working syscalls in Emscripten (GH-31757) Mar 8, 2022
@tiran
tiran merged commit 5081e78 into python:main Mar 8, 2022
@tiran
tiran deleted the bpo-40280-even-more-syscalls branch March 8, 2022 11:17
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 8, 2022
@brettcannon
brettcannon self-requested a review March 8, 2022 20:09
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon Awaiting requested review from brettcannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.