GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45138: Fix regression in GH-28240 by erlend-aasland · Pull Request #31783 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Mar 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue45138

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland added 5 commits March 9, 2022 10:15
Erlend E. Aasland
Skip test_trace_too_much_expanded_sql on SQLite pre 3.14.0
8a372a3
Erlend E. Aasland
Remove What's New entry
260f242
Erlend E. Aasland
Amend NEWS entry
86f284d
Erlend E. Aasland
Amend test comment
e11e0f9
Erlend E. Aasland
Amend NEWS entry with regression info
0ab2575
@bedevere-bot bedevere-bot added the awaiting review label Mar 9, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 9, 2022
@erlend-aasland

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

cc. @JelleZijlstra @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Mar 9, 2022
@erlend-aasland erlend-aasland reopened this Mar 9, 2022
JelleZijlstra
JelleZijlstra approved these changes Mar 9, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I can merge it once we're both happy with it (cc @gvanrossum).

We should also test with buildbots though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Mar 9, 2022
@erlend-aasland

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

We should also test with buildbots though.

I tried adding the buildbot label via the GH app, but for some reason it does not work. Feel free to send it to the bots now.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022
@bedevere-bot

bedevere-bot commented Mar 9, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 0ab2575 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Mar 9, 2022
@erlend-aasland

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

s390x SLES PR failed. This PR needs more work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Mar 9, 2022

Copy link
Copy Markdown
Member

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Mar 9, 2022

Copy link
Copy Markdown
Contributor Author

IIUC the buildbots are still red. Maybe it's time to roll back the original commit? Then you can fix it without so much stress.

Yep, there are some red ones left; I think we should revert now, especially given Łukasz' recent plea about keeping the bots green. I'll close this and submit a new PR in a couple of days.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Mar 9, 2022
@erlend-aasland
erlend-aasland deleted the fix-trace branch March 9, 2022 17:10
@JelleZijlstra

JelleZijlstra commented Mar 9, 2022

Copy link
Copy Markdown
Member

Thanks, yes I was also going to suggest reverting.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Apr 10, 2022
sqlite3 regression: bound values are not expanded in traced statements #89301
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@erlend-aasland @bedevere-bot @gvanrossum @JelleZijlstra @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.