GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40465: Document random module changes in 3.11 What's new by hrnciar · Pull Request #31818 · python/cpython

Conversation

@hrnciar

@hrnciar hrnciar commented Mar 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://bugs.python.org/issue40465

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hrnciar
hrnciar requested a review from rhettinger as a code owner March 11, 2022 13:19
@bedevere-bot bedevere-bot added the awaiting review label Mar 11, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 11, 2022
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Mar 11, 2022
@AlexWaygood AlexWaygood added the skip news label Mar 11, 2022
@hrnciar
hrnciar force-pushed the doc-update branch from b8926aa to 83b3d93 Compare March 14, 2022 06:47
hugovk
hugovk requested changes Mar 17, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Outdated

@hugovk hugovk Mar 17, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix the docs build:

Suggested change
* The *population* parameter of :func: `random.sample` must be a sequence.
* The *population* parameter of :func:`random.sample` must be a sequence.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 17, 2022
serhiy-storchaka
serhiy-storchaka previously requested changes Mar 17, 2022
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a correct place for this note because it is not a new feature. From user's point of view it is a breaking change which can break a code that worked before (even if it issued deprecation warnings). It should be documented in sections "Porting to Python 3.11", subsection "Changes in the Python API" or in section "Removed" (different changes may be in different sections).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 17, 2022
@bedevere-bot

bedevere-bot commented Mar 17, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Mar 17, 2022
@hrnciar
hrnciar force-pushed the doc-update branch from 83b3d93 to c2d925c Compare March 21, 2022 10:59
@hrnciar hrnciar changed the title Document random module changes in 3.11 What's new bpo-40465: Document random module changes in 3.11 What's new Mar 21, 2022
@hrnciar
bpo-40465: Document random module changes in 3.11 What's new
c3a3c38
@hrnciar
hrnciar force-pushed the doc-update branch from 9d1a12d to c3a3c38 Compare March 21, 2022 11:04
@hrnciar
hrnciar requested a review from serhiy-storchaka March 21, 2022 12:23
@vstinner

vstinner commented Mar 24, 2022

Copy link
Copy Markdown
Member

@serhiy-storchaka:

It should be documented in sections "Porting to Python 3.11"

Done: @hrnciar moved the What's New entry to Porting to Python 3.11 > Changes in the Python API.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner dismissed serhiy-storchaka’s stale review March 24, 2022 13:19

Change addressed

serhiy-storchaka
serhiy-storchaka approved these changes Mar 24, 2022
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 12c0012 into python:main Mar 24, 2022
@vstinner

vstinner commented Mar 24, 2022

Copy link
Copy Markdown
Member

This change is related to 70a071d
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Mar 24, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post-merge review (@serhiy-storchaka was faster than me :-)): LGTM! This change properly describes https://bugs.python.org/issue40465 changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka

serhiy-storchaka commented Mar 24, 2022

Copy link
Copy Markdown
Member

BTW it was first time I used GitHub client for Android.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger rhettinger mentioned this pull request Aug 23, 2023
Deprecate the optional *random* argument to random.shuffle() #84645
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@hugovk hugovk hugovk requested changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting changes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@hrnciar @bedevere-bot @vstinner @serhiy-storchaka @hugovk @the-knights-who-say-ni @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.