GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46644: Fix test_typing test broken by GH-31151 due to a merge race by JelleZijlstra · Pull Request #31833 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Mar 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue46644

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
bpo-46644: fix test
78191bf
@JelleZijlstra JelleZijlstra added the skip news label Mar 12, 2022
@JelleZijlstra
JelleZijlstra requested review from Fidget-Spinner and gvanrossum as code owners March 12, 2022 01:49
@bedevere-bot bedevere-bot added the awaiting core review label Mar 12, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 12, 2022
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 12, 2022
@vstinner

vstinner commented Mar 12, 2022

Copy link
Copy Markdown
Member

"fix test" is not a great commit title, it doesn't help future developers who will read commits. Would you mind to elaborate that?

Which test? Why was it failing? Is it related to a recent change? etc.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra changed the title bpo-46644: fix test bpo-46644: Fix test_typing test broken by GH-31151 due to a merge race Mar 12, 2022
@JelleZijlstra

JelleZijlstra commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

Good point, how is the new title?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Mar 12, 2022

Copy link
Copy Markdown
Member

Good point, how is the new title?

Much better. Practical issue: be careful when you click on the Merge button, GitHub uses the commit title and commit message from Git, not the one on the web page. It's confusing. You can fix it with the form open by GitHub.

I avoid the automerge label to avoid this trap.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented Mar 12, 2022

Copy link
Copy Markdown
Member Author

Yes, I always read over the commit message when I merge :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra merged commit 7517437 into python:main Mar 12, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Mar 12, 2022
@JelleZijlstra
JelleZijlstra deleted the fixtyping branch March 12, 2022 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @vstinner @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.