GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43224: Add tests for TypeVarTuple substitution in Annotated by mrahtz · Pull Request #31846 · python/cpython

Conversation

@mrahtz

@mrahtz mrahtz commented Mar 13, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

At some point I guess we should add tests for the native tuple too, once #31828 or similar is in.

@JelleZijlstra Does this assuage the concerns you mentioned about Annotated in #31021 (review)?

@@GBeauregard too, since Jelle also mentioned you in that thread - is there anything else we should test for here?

https://bugs.python.org/issue43224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrahtz
Add tests for TypeVarTuple substitution in Annotated
36566bc
@mrahtz
mrahtz requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 13, 2022 13:29
@bedevere-bot bedevere-bot added the awaiting review label Mar 13, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 13, 2022
@JelleZijlstra JelleZijlstra added the skip news label Mar 16, 2022
JelleZijlstra
JelleZijlstra reviewed Mar 16, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The tests are good but it's a bit unfortunate if we can't use Annotated around a TypeVarTuple at all.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/typing.py
raise TypeError("Annotated[...] should be used "
"with at least two arguments (a type and an "
"annotation).")
if _is_unpacked_typevartuple(params[0]):

@JelleZijlstra JelleZijlstra Mar 16, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to explicitly disallow this at runtime.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mrahtz mrahtz Mar 19, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, but then how should we handle situations like this?

A = Annotated[Unpack[Ts], "foo"]
B = A[int, str]

Annotated[int, str, "foo"] wouldn't be valid. We could do some kind of automatic tuple wrapping, Annotated[tuple[int, str], "foo", but that would be inconsistent with how we handle TypeVarTuple substitution elsewhere.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Apr 15, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, and sorry for not responding to this earlier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrahtz mrahtz mannequin mentioned this pull request Apr 11, 2022
Add support for PEP 646 #87390
Closed
@JelleZijlstra
JelleZijlstra self-requested a review April 15, 2022 23:11
JelleZijlstra
JelleZijlstra approved these changes Apr 15, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 15, 2022
@JelleZijlstra
Merge branch 'main' into annotated-typevartuple
8f06a98
@JelleZijlstra JelleZijlstra self-assigned this Apr 15, 2022
@JelleZijlstra
JelleZijlstra merged commit f2bc12f into python:main Apr 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 16, 2022
@mrahtz
mrahtz deleted the annotated-typevartuple branch May 1, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mrahtz @JelleZijlstra @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.