GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46841: Don't scan backwards in bytecode. by markshannon · Pull Request #31901 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Mar 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Avoid scanning backwards when working out whether to trace a line, or whether we are in a yield from.

This should help with #31888.

https://bugs.python.org/issue46841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Don't scan backwards in bytecode when looking for execution context.
1d67c85
@markshannon markshannon added the skip news label Mar 15, 2022
@markshannon
markshannon requested a review from 1st1 as a code owner March 15, 2022 12:27
@markshannon markshannon assigned brandtbucher Mar 15, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Mar 15, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 15, 2022
@markshannon markshannon changed the title bpo-46841: Don't scan backwards in bytecode when looking for execution context. bpo-46841: Don't scan backwards in bytecode. Mar 15, 2022
@brandtbucher brandtbucher mentioned this pull request Mar 15, 2022
Inline caching faster-cpython/ideas#310
Closed
21 of 26 tasks
brandtbucher
brandtbucher approved these changes Mar 15, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I'll take care of the merge conflict so I can use this over in #31888.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 15, 2022
@brandtbucher
Merge branch 'main' into no-backward-scanning
1ce3c67
@brandtbucher
brandtbucher merged commit 49e1e1e into python:main Mar 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 16, 2022
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Inline bytecode caches #90997
Closed
@markshannon
markshannon deleted the no-backward-scanning branch September 26, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@1st1 1st1 Awaiting requested review from 1st1

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @brandtbucher @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.