GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34861: Make cumtime the default sorting key for cProfile by DanielNoord · Pull Request #31929 · python/cpython

Conversation

@DanielNoord

@DanielNoord DanielNoord commented Mar 16, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Note: This does not fully resolve bpo-34861, but only tackles one of the two issues identified.

This is a resubmit of #9655 and some of the changes that were discussed there.

@pablogsal I'm tagging you since you basically asked for the PR to be split and said that this change looked good. Sorry if the ping is uncalled for.

I have also updated the documentation to better reflect what a new call to cProfile.run('re.compile("foo|bar")') would look like. This also shows that we no longer sort on standard name.

https://bugs.python.org/issue34861

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
boxed reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@DanielNoord @boxed
bpo-34861: Make cumtime the default sorting key for cProfile
0c126f0 
Co-authored-by: =?UTF-8?q?Anders=20Hovm=C3=B6ller?= <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Mar 16, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 16, 2022
@DanielNoord DanielNoord closed this Mar 23, 2022
@DanielNoord DanielNoord reopened this Mar 23, 2022
MaxwellDupre
MaxwellDupre approved these changes Mar 26, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DanielNoord reacted with laugh emoji
All reactions
  • 😄 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 26, 2022
pablogsal
pablogsal approved these changes Mar 30, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 30, 2022
@pablogsal
pablogsal merged commit 75eee1d into python:main Mar 30, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 30, 2022
@DanielNoord
DanielNoord deleted the fix-issue-34861 branch March 30, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
+1 more reviewer
@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@DanielNoord @pablogsal @MaxwellDupre @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.