GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91152: IDLE: Drop workarounds for old Tk versions by serhiy-storchaka · Pull Request #31962 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 17, 2022 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Drop support of Tcl/Tk older than 8.5.12 #91152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-46996: IDLE: Drop workarounds for old Tk versions
070b695
@serhiy-storchaka serhiy-storchaka added the skip news label Mar 17, 2022
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy as a code owner March 17, 2022 16:32
@bedevere-bot bedevere-bot added the awaiting core review label Mar 17, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 17, 2022
terryjreedy
terryjreedy approved these changes Mar 17, 2022
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. I considered whether the existing tkinter import failure message should be changed and decided that it is good enough, as well as extremely rare.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 17, 2022
@serhiy-storchaka
serhiy-storchaka merged commit 383a3be into python:main Mar 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 19, 2022
@serhiy-storchaka
serhiy-storchaka deleted the idle-drop-old-tk branch March 19, 2022 15:14
@terryjreedy terryjreedy changed the title bpo-46996: IDLE: Drop workarounds for old Tk versions gh-91152: IDLE: Drop workarounds for old Tk versions Aug 9, 2022
@terryjreedy terryjreedy mentioned this pull request Aug 9, 2022
Drop support of Tcl/Tk older than 8.5.12 #91152
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @terryjreedy @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.