GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Skip socket, fork, subprocess tests on Emscripten by tiran · Pull Request #31986 · python/cpython

Conversation

@tiran

@tiran tiran commented Mar 19, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add requires_fork and requires_subprocess to more tests
  • Skip extension import tests if dlopen is not available
  • Don't assume that _testcapi is a shared extension
  • Skip a lot of socket tests that don't work on Emscripten
  • Skip mmap tests, mmap emulation is incomplete
  • venv does not work yet
  • Cannot get libc from executable

The "entire" test suite is now passing on Emscripten with EMSDK from git head (91 suites are skipped).

https://bugs.python.org/issue40280

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

emmatyping reacted with hooray emoji
All reactions
  • 🎉 1 reaction
tiran added 9 commits March 19, 2022 10:15
@tiran
bpo-40280: Add requires_fork and subprocess to more tests
8c79de4
@tiran
bpo-40280: Skip extension tests if dlopen is not available
a528e66
@tiran
Don't assume that _testcapi is a shared extension
d578fa4
@tiran
Skip socket tests that don't work on Emscripten
a05977f
@tiran
mmap emulation is incomplete
126f427
@tiran
venv does not work yet
98b30c3
@tiran
Cannot get libc from executable
a9102ec
@tiran
Skip lots of socket tests
3313066
@tiran
blurb
2face97
@bedevere-bot bedevere-bot added the awaiting core review label Mar 19, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 19, 2022
@tiran
tiran requested a review from brettcannon March 19, 2022 09:26
@tiran

tiran commented Mar 19, 2022

Copy link
Copy Markdown
Member Author
== Tests result: SUCCESS ==

341 tests OK.

91 tests skipped:
    test__xxsubinterpreters test_asyncgen test_asynchat test_asyncio
    test_asyncore test_check_c_globals test_clinic test_cmd_line
    test_concurrent_futures test_contextlib_async test_ctypes
    test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_doctest
    test_docxmlrpc test_embed test_epoll test_faulthandler test_fcntl
    test_file_eintr test_fork1 test_ftplib test_gdb test_grp
    test_httplib test_httpservers test_idle test_imaplib
    test_interpreters test_ioctl test_kqueue test_lzma test_mmap
    test_msilib test_multiprocessing_fork
    test_multiprocessing_forkserver test_multiprocessing_main_handling
    test_multiprocessing_spawn test_nis test_openpty test_ossaudiodev
    test_pdb test_poll test_poplib test_pty test_pwd test_readline
    test_regrtest test_repl test_select test_selectors test_smtplib
    test_smtpnet test_socket test_socketserver test_spwd test_sqlite3
    test_ssl test_stable_abi_ctypes test_startfile test_subprocess
    test_sys_settrace test_syslog test_tcl test_telnetlib test_tix
    test_tk test_tools test_ttk_guionly test_ttk_textonly test_turtle
    test_urllib2 test_urllib2_localnet test_urllib2net test_urllibnet
    test_venv test_wait3 test_wait4 test_webbrowser test_winconsoleio
    test_winreg test_winsound test_wsgiref test_xmlrpc test_xmlrpc_net
    test_xxlimited test_zipfile64 test_zipimport_support test_zoneinfo

1 test run no tests:
    test_dtrace

Total duration: 11 min 13 sec
Tests result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@tiran
Fix doctest line number
c6c41f3
@tiran
tiran marked this pull request as ready for review March 19, 2022 10:23
@tiran
tiran requested review from a team, 1st1, asvetlov, berkerpeksag, cjw296, lysnikolaou, pablogsal and vsajip as code owners March 19, 2022 10:23
@tiran
Fix LTO build, prepare for dlopen() side modules
475c127
brettcannon
brettcannon approved these changes Mar 21, 2022
View reviewed changes
Comment thread Lib/test/support/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Tests/2022-03-19-10-25-04.bpo-40280.wBRSel.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Misc/NEWS.d/next/Tests/2022-03-19-10-25-04.bpo-40280.wBRSel.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 21, 2022
tiran and others added 2 commits March 22, 2022 08:33
@tiran @brettcannon
Apply suggestions from code review
b14c9da
Co-authored-by: Brett Cannon <[email protected]>
@tiran
Document requires_working_socket
3db0a48
@tiran tiran added the 🤖 automerge label Mar 22, 2022
@miss-islington
miss-islington merged commit deeaac4 into python:main Mar 22, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 22, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@cjw296 cjw296 Awaiting requested review from cjw296
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.