GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-43224: Unpack concrete tuple types into a sequence of types by serhiy-storchaka · Pull Request #32030 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

G[*tuple[int, str]] == G[int, str]

https://bugs.python.org/issue43224

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 21, 2022
@serhiy-storchaka
serhiy-storchaka requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners March 21, 2022 17:47
@bedevere-bot bedevere-bot added the awaiting core review label Mar 21, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 21, 2022
@serhiy-storchaka
bpo-43224: Unpack concrete tuple types into a sequence of types
bc310d5 
G[*tuple[int, str]] == G[int, str]
@serhiy-storchaka
serhiy-storchaka force-pushed the unpack-concrete-tuple-types branch from cf4a80f to bc310d5 Compare March 21, 2022 18:47
@serhiy-storchaka serhiy-storchaka added the skip news label Mar 22, 2022
@JelleZijlstra

JelleZijlstra commented Mar 23, 2022

Copy link
Copy Markdown
Member

I'd rather not do this for the reasons @mrahtz explained elsewhere.

Another point: what about Unpack[Annotated[tuple[int, str], "whatever"]]?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra reviewed Apr 11, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should do this (see also @mrahtz's comment at #91162 (comment)):

  • It would make Unpack[tuple[int, str]] not the same as *tuple[int, str].
  • def f(*args: *tuple[int, str]) would end up with int in its __annotations__ because of the way we implemented * there.
  • For runtime users of typing, in my experience it's better to keep information around than to simplify. If we simplify, runtime introspection can't reconstruct what the user meant; if we don't simplify, tool authors can probably deal with it easily.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrahtz

mrahtz commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

+1 to what @JelleZijlstra says.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mrahtz mrahtz mannequin mentioned this pull request Apr 11, 2022
Add support for PEP 646 #87390
Closed
@AlexWaygood AlexWaygood added the topic-typing label Apr 13, 2022
@serhiy-storchaka serhiy-storchaka closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip news topic-typing type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@serhiy-storchaka @JelleZijlstra @mrahtz @the-knights-who-say-ni @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.