GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46841: remove no-longer-used macro UPDATE_PREV_INSTR_OPARG by iritkatriel · Pull Request #32100 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Mar 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This macro is no longer used following the inline-caches changes.

https://bugs.python.org/issue46841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
bpo-46841: remove no-longer-used macro UPDATE_PREV_INSTR_OPARG
c9f8838
@iritkatriel
iritkatriel requested a review from brandtbucher March 24, 2022 17:40
@iritkatriel
iritkatriel requested a review from markshannon as a code owner March 24, 2022 17:40
@bedevere-bot bedevere-bot added the awaiting core review label Mar 24, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 24, 2022
@iritkatriel iritkatriel added the skip news label Mar 24, 2022
brandtbucher
brandtbucher approved these changes Mar 24, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Mar 24, 2022
@brandtbucher brandtbucher mentioned this pull request Mar 24, 2022
Inline caching faster-cpython/ideas#310
Closed
21 of 26 tasks
@iritkatriel
iritkatriel merged commit 2f49b97 into python:main Mar 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Mar 24, 2022
@iritkatriel
iritkatriel deleted the bpo-46841-remove-macro branch March 24, 2022 18:54
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Inline bytecode caches #90997
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @brandtbucher @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.