GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-n/a: Updated ccbench.py used to assess multithreading by Sophist-UK · Pull Request #32135 · python/cpython

Conversation

@Sophist-UK

@Sophist-UK Sophist-UK commented Mar 26, 2022

Copy link
Copy Markdown

As used in faster-cpython/ideas#328.

Guido asked me to submit my changes as a PR so that the enhancements would be available to others.

Because this is not a PR on Python product code - but rather an update of an incidental performance measurement script - an issue number is not relevant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jab reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@Sophist-UK
Updated ccbench.py used to assess multithreading
5640a15
As used in faster-cpython/ideas#328.

Guido asked me to submit my changes as a PR so that the enhancements would be available to others.
@bedevere-bot bedevere-bot added the awaiting review label Mar 26, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Mar 26, 2022
@the-knights-who-say-ni

the-knights-who-say-ni commented Mar 26, 2022

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@Sophist-UK

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Sophist-UK
Tidy code a little
0a98791
@the-knights-who-say-ni the-knights-who-say-ni added CLA signed and removed CLA not signed labels Apr 2, 2022
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@arhadthedev arhadthedev mentioned this pull request Feb 12, 2023
gh-100176: Remove outdated Tools/{io,cc,string}bench #101853
Merged
@hugovk hugovk closed this in #101853 Feb 17, 2024
@Sophist-UK Sophist-UK mentioned this pull request Feb 18, 2024
Move Benchmarks From Tools/ to the pyperformance Repo #97680
Open
@Sophist-UK

Sophist-UK commented Feb 18, 2024

Copy link
Copy Markdown
Author

I would have commented sooner had I known that this was about to happen. It would have been helpful if someone had commented in this PR that this was being considered so that I would have been notified and might have had a chance to comment before it happened.

I believe it was clear from the faster-cpython/ideas#328 that the ccbench script is still useful - because it clearly identifies an ongoing performance issue when multithreading with one or more CPU-heavy threads, and indeed it was @gvanrossum Guido himself who requested this PR.

That said, I do understand that performance scripts do not really have a place in the cpython source code repo, but unfortunately I do not have the time to rework the updated ccbench script for the pyperformance suite, so I guess it is going to just disappear.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently

ericsnowcurrently commented Feb 20, 2024

Copy link
Copy Markdown
Member

@hugovk ^^^

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@hugovk

hugovk commented Feb 20, 2024

Copy link
Copy Markdown
Member

Thanks for the ping. Let's continue in the issue, I already replied to the identical comment there: #97680 (comment)

(And for completeness, there's also an identical comment at d.p.o.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Sophist-UK @the-knights-who-say-ni @ericsnowcurrently @hugovk @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.