GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-46841: Use a `bytes` object for `_co_code_adaptive` by brandtbucher · Pull Request #32205 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Mar 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The memoryview was a fun idea, but it actually creates some subtle memory management issues (since it can possibly outlive the code object it references).

While we could fix this by hacking around inside of the returned memoryview or giving code objects full buffer protocol support, a bytes object is totally fine here (and it even makes disassembly a bit easier).

https://bugs.python.org/issue46841

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 2 commits March 30, 2022 16:32
@brandtbucher
Turn _co_code_adaptive into a bytes object
2ab9d4f
@brandtbucher
Remove trailing whitespace
fb65b45
@brandtbucher brandtbucher added type-bug An unexpected behavior, bug, or error skip news labels Mar 30, 2022
@brandtbucher
brandtbucher requested a review from markshannon as a code owner March 30, 2022 23:41
@bedevere-bot bedevere-bot added the awaiting core review label Mar 30, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 30, 2022
@brandtbucher brandtbucher mentioned this pull request Mar 30, 2022
Inline caching faster-cpython/ideas#310
Closed
21 of 26 tasks
@markshannon
markshannon merged commit ae9de82 into python:main Apr 1, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 1, 2022
@brandtbucher brandtbucher mentioned this pull request Apr 10, 2022
Inline bytecode caches #90997
Closed
@brandtbucher
brandtbucher deleted the co-code-adaptive-bytes branch July 21, 2022 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @markshannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.