GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Detect if WASM platform supports threading by tiran · Pull Request #32243 · python/cpython

Conversation

@tiran

@tiran tiran commented Apr 1, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue40280

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Apr 1, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 1, 2022
@tiran
tiran requested a review from brettcannon April 1, 2022 21:11
@tiran tiran mentioned this pull request Apr 1, 2022
Review CPython patches / tests and contribute upstream pyodide/pyodide#2000
Closed
brettcannon
brettcannon approved these changes Apr 1, 2022
View reviewed changes
Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 1, 2022
tiran and others added 2 commits April 2, 2022 10:45
@tiran
bpo-40280: Detect if WASM platform supports threading
934bad8
@tiran @brettcannon
Apply suggestions from code review
413398a
Co-authored-by: Brett Cannon <[email protected]>
@tiran
tiran force-pushed the bpo-40280-thread branch from ef7ce76 to 413398a Compare April 2, 2022 07:45
@tiran tiran added skip news 🤖 automerge labels Apr 2, 2022
@miss-islington

miss-islington commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

@tiran: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit 59be9cd into python:main Apr 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 2, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tiran @miss-islington @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.