GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-40280: Detect missing threading on WASM platforms (GH-32352) by tiran · Pull Request #32352 · python/cpython

Conversation

@tiran

@tiran tiran commented Apr 6, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

WASM Emscripten builds for browsers and WASI don't have pthread support. The threading API is stubbed. The changeset adds a test decorator that skips tests which required threading.

https://bugs.python.org/issue40280

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
tiran requested review from a team, 1st1, brettcannon, encukou, ericsnowcurrently, ethanfurman, ncoghlan, rhettinger, vsajip and warsaw as code owners April 6, 2022 08:20
@bedevere-bot bedevere-bot added the awaiting core review label Apr 6, 2022
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Apr 6, 2022
@tiran tiran changed the title bpo-40280: Detect missing threading bpo-40280: Detect missing threading on WASM platforms Apr 6, 2022
@tiran tiran mentioned this pull request Apr 6, 2022
Review CPython patches / tests and contribute upstream pyodide/pyodide#2000
Closed
brettcannon
brettcannon approved these changes Apr 6, 2022
View reviewed changes
Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/support/threading_helper.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_sys.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 6, 2022
tiran and others added 4 commits April 7, 2022 08:49
@tiran
bpo-40280: Detect missing threading
9ca8678
@tiran
Move dlopen patch to separate PR
5cb44c8
@tiran @brettcannon
Mind the full stop
c6a985a 
Co-authored-by: Brett Cannon <[email protected]>
@tiran
Reformat code
ee4016b
@tiran
tiran force-pushed the bpo-40280-threading-dlopen branch from 6050f5f to ee4016b Compare April 7, 2022 06:51
@tiran tiran changed the title bpo-40280: Detect missing threading on WASM platforms bpo-40280: Detect missing threading on WASM platforms (GH-32352) Apr 7, 2022
@tiran
tiran merged commit 2b16a08 into python:main Apr 7, 2022
@tiran
tiran deleted the bpo-40280-threading-dlopen branch April 7, 2022 07:22
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 7, 2022
@SimonBiggs SimonBiggs mannequin mentioned this pull request Jun 7, 2022
Consider supporting emscripten/webassembly as a build target #84461
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@encukou encukou Awaiting requested review from encukou
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @brettcannon @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.