GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-27541: Reprs of subclasses of some classes now contain actual type name. by serhiy-storchaka · Pull Request #3631 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Affected classes are bytearray, array, deque, defaultdict, count and repeat.

https://bugs.python.org/issue27541

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger September 17, 2017 17:06
@serhiy-storchaka
serhiy-storchaka requested a review from ncoghlan as a code owner September 17, 2017 17:06
@bedevere-bot bedevere-bot added the awaiting merge label Sep 17, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 17, 2017
@serhiy-storchaka
serhiy-storchaka force-pushed the collections-repr-type-name branch from e8c9db9 to 9df3e22 Compare September 17, 2017 17:06
rhettinger
rhettinger approved these changes Sep 17, 2017
View reviewed changes

@rhettinger rhettinger left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only one I have misgivings about is itertools.count() doesn't seem to be meaningfully subclassable. But changing the repr for count doesn't have any negative effect, so +0 for changing it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-27541: Reprs of subclasses of some classes now contain actual typ…
6e75a20 
…e name.

Affected classes are bytearray, array, deque, defaultdict, count and repeat.
@serhiy-storchaka

serhiy-storchaka commented Sep 17, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Maybe make count and repeat not subclassable?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka force-pushed the collections-repr-type-name branch from 9df3e22 to 6e75a20 Compare September 17, 2017 18:16
@serhiy-storchaka
serhiy-storchaka merged commit b3a7796 into python:master Sep 21, 2017
@serhiy-storchaka
serhiy-storchaka deleted the collections-repr-type-name branch September 21, 2017 11:24
@Mariatta Mariatta removed the awaiting merge label Oct 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes
@ncoghlan ncoghlan Awaiting requested review from ncoghlan

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @rhettinger @Mariatta @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.