GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32787: Better error handling in ctypes. by serhiy-storchaka · Pull Request #3727 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 24, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue32787

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-31572: Get rid of PyObject_HasAttrString() in ctypes.
4c77e8b
@serhiy-storchaka serhiy-storchaka added skip news type-bug An unexpected behavior, bug, or error labels Sep 24, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Sep 24, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 24, 2017
serhiy-storchaka added 6 commits November 11, 2017 16:44
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
de995da
@serhiy-storchaka
Fix error handling for _pack_.
ed1fb01
@serhiy-storchaka
Don't silence errors when look up in a dict.
70d31ba
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
f8b64f1
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
34c40e0
@serhiy-storchaka
Use _PyObject_LookupAttrId().
e10a467
eric-wieser
eric-wieser reviewed Feb 7, 2018
View reviewed changes
Comment thread Modules/_ctypes/stgdict.c
}

len = PySequence_Length(fields);
len = PySequence_Size(fields);

@eric-wieser eric-wieser Feb 7, 2018

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Length → Size?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@serhiy-storchaka serhiy-storchaka Feb 7, 2018

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PySequence_Size is more commonly used. PySequence_Length is just an outdated alias of PySequence_Size.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
serhiy-storchaka added 2 commits February 7, 2018 13:37
@serhiy-storchaka
More changes.
d7bb65a
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
149d4b9
@serhiy-storchaka serhiy-storchaka changed the title bpo-31572: Get rid of PyObject_HasAttrString() in ctypes. bpo-32787: Better error handling in ctypes. Feb 7, 2018
serhiy-storchaka added 2 commits September 22, 2018 22:09
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
423ac29
@serhiy-storchaka
Merge branch 'master' into ctypes-no-hasattr
4cf77fe
@serhiy-storchaka
serhiy-storchaka merged commit 398bd27 into python:master Dec 5, 2018
@bedevere-bot

bedevere-bot commented Dec 5, 2018

Copy link
Copy Markdown

@serhiy-storchaka: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 5, 2018
@serhiy-storchaka
serhiy-storchaka deleted the ctypes-no-hasattr branch December 5, 2018 14:44
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
Avoid suppressing all exceptions in PyObject_HasAttr() #75753
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@eric-wieser eric-wieser eric-wieser left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @bedevere-bot @eric-wieser @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.