GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — allow path-like objects to be cwd on windows by benjaminp · Pull Request #389 · python/cpython

Conversation

@benjaminp

@benjaminp benjaminp commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

#157 added the test, but it's currently (correctly) broken on windows.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjaminp
allow path-like objects to be cwd on windows
e431c29 
#157 added the test, but it's currently (correctly) broken on windows.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 2, 2017
@benjaminp
benjaminp merged commit f522792 into master Mar 2, 2017
@benjaminp
benjaminp deleted the benjamin-cwd-windows branch March 2, 2017 07:04
@Khold6458

Khold6458 commented Mar 7, 2017

Copy link
Copy Markdown

I believe this (and the subsequent fix in commit d874b8f) need to be backported to 3.6.

(For context, I have just compiled Python from source for the first time and landed here after running tests and searching around a bit.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@benjaminp @Khold6458 @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.