GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-31779: Prevent assertion failures and a crash when using an uninitialized struct.Struct object by orenmn · Pull Request #3984 · python/cpython

Conversation

@orenmn

@orenmn orenmn commented Oct 13, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In addition, add tests to test_struct to make sure the assertion failures and the crash are no more.

https://bugs.python.org/issue31779

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
orenmn added 5 commits October 13, 2017 13:58
@orenmn
init commit
4650244
@orenmn
make the tests more realistic
f8a43d1
@orenmn
check only s_codes
3f3be9d
@orenmn
remove starting underscore in the helper's name.
e5199f7
@orenmn
improve the error message
0e64244
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 13, 2017
@bedevere-bot bedevere-bot added the awaiting review label Oct 13, 2017
pppery
pppery reviewed Sep 16, 2018
View reviewed changes
Comment thread Lib/test/test_struct.py
s2 = struct.Struct(s.format.encode())
self.assertEqual(s2.format, s.format)

@support.cpython_only

@pppery pppery Sep 16, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test cpython only?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Feb 28, 2022

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Feb 28, 2022
MaxwellDupre
MaxwellDupre suggested changes Mar 29, 2022
View reviewed changes

@MaxwellDupre MaxwellDupre left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

struct_obj.iter_unpack(b'foo')
Traceback (most recent call last):
File "", line 1, in
ValueError: Struct.init() wasn't called

Can you respond to:
pppery on 16 Sep 2018
Why is this test cpython only?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Mar 29, 2022
@orenmn orenmn mannequin mentioned this pull request Jul 3, 2022
assertion failures and a crash when using an uninitialized struct.Struct object #75960
Closed
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jul 29, 2022
@kumaraditya303

kumaraditya303 commented Sep 25, 2022

Copy link
Copy Markdown
Contributor

Superseded by #94532
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@pppery pppery pppery left review comments
@MaxwellDupre MaxwellDupre MaxwellDupre requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@orenmn @kumaraditya303 @MaxwellDupre @pppery @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.