GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated. by brianfcoleman · Pull Request #402 · python/cpython

Conversation

@brianfcoleman

@brianfcoleman brianfcoleman commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

On PyMem_Realloc failure, _PyCode_SetExtra should free co_extra if
co_extra->ce_extras could not be allocated.
On PyMem_Realloc success, _PyCode_SetExtra should set all unused slots in
co_extra->ce_extras to NULL.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brianfcoleman
bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is
c6069c5 
allocated.

On PyMem_Realloc failure, _PyCode_SetExtra should free co_extra if
co_extra->ce_extras could not be allocated.
On PyMem_Realloc success, _PyCode_SetExtra should set all unused slots in
co_extra->ce_extras to NULL.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 2, 2017
@brianfcoleman brianfcoleman mentioned this pull request Mar 2, 2017
bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated #376
Merged
serhiy-storchaka
serhiy-storchaka approved these changes Mar 2, 2017
View reviewed changes
@serhiy-storchaka
Merge branch '3.6' into bpo-29683-3.6
5751be1
@berkerpeksag berkerpeksag changed the title bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated. [3.6] bpo-29683 - Fixes to _PyCode_SetExtra when co_extra->ce->extras is allocated. Mar 2, 2017
@berkerpeksag berkerpeksag added the cherry-pick for 3.6 label Mar 2, 2017
@serhiy-storchaka
serhiy-storchaka merged commit a6e8493 into python:3.6 Mar 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brianfcoleman @serhiy-storchaka @berkerpeksag @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.