GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32075: Expose ZipImporter Type Object in the include header files. by AraHaan · Pull Request #4470 · python/cpython

Conversation

@AraHaan

@AraHaan AraHaan commented Nov 19, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This should hopefully allow subclassing the zipimporter class outside of
the Python layer as well.

See the issue at bpo for more information as to why this needs exposed in the include files.

https://bugs.python.org/issue32075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AraHaan
bpo-32075: Expose ZipImporter Type Object in the include header files.
2db24da 
This should hopefully allow subclassing the zipimporter class outside of
the Python layer as well.
@AraHaan
AraHaan requested a review from a team November 19, 2017 20:33
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 19, 2017
@bedevere-bot bedevere-bot added the awaiting review label Nov 19, 2017
AraHaan added 10 commits November 19, 2017 15:46
@AraHaan
bpo-32075: Fix Windows CI.
297288a
@AraHaan
bpo-32075: Remove zipimport.h from Python.h.
194c7b4 
Seems on Windows compile fails for some reason when in Python.h on a
module.
@AraHaan
bpo-32075: Fixed zipimport.c.
2c7656c
@AraHaan
bpo-32075: fix zipimport.h and add to Python.h.
1901323
@AraHaan
bpo-32075: Make ZipImporter_Type non-static.
6cc282a
@AraHaan
Added an zipimporter doc and some changes.
3df3f09
@AraHaan
bpo-32075: Reference zipimporter.rst in docs.
6a31123
@AraHaan
bpo-32075: Update zipimport clinic manually.
87f56fc
@AraHaan
bpo-32075: Actually regenerate clinic.
d1db629 
Should be the last of my ZipImporter clinic problems.
@AraHaan
bpo-32075: Add news entry.
8826977
@AraHaan AraHaan closed this Nov 20, 2017
@AraHaan AraHaan reopened this Nov 20, 2017
@AraHaan
bpo-32075: changed docs.
e742b93
@AraHaan
AraHaan changed the base branch from master to 3.6 November 20, 2017 08:45
@AraHaan
AraHaan changed the base branch from 3.6 to master November 20, 2017 08:46
brettcannon
brettcannon reviewed Nov 21, 2017
View reviewed changes
Comment thread Include/zipimport.h
extern "C" {
#endif

PyAPI_DATA(PyTypeObject) PyZipImporter_Type;

@brettcannon brettcannon Nov 21, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the rest of the file shouldn't be part of the stable ABI.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AraHaan AraHaan Nov 21, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then how would someone be able to subclass or subtype the zip importer in their C code?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@brettcannon brettcannon Nov 21, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying only on the stable ABI is an opt-in thing when you build an extension, so leaving this out of it won't prevent it from being available overall, just in a certain instance.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon

brettcannon commented Nov 21, 2017

Copy link
Copy Markdown
Member

I personally don't have time to review and contemplate the ramifications of this, but I would suggest that any changes not be part of the stable ABI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Sep 19, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

zipimport have been rewritten in pure Python (bpo-25711).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this Sep 19, 2018
@AraHaan
AraHaan deleted the issue32075 branch September 19, 2018 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AraHaan @brettcannon @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.