GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-32267: Fix parsing tz offsets microseconds shorter than 6 by mariocj89 · Pull Request #4781 · python/cpython

Conversation

@mariocj89

@mariocj89 mariocj89 commented Dec 10, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

As the remainder is directly parsed as an int, strings like .600 will be parsed as 600 microsecond rather than milliseconds.

I've added no news entries as it was included in #4015 and I think it has not been released yet. Please let me know if one should be added.

https://bugs.python.org/issue32267

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pganssle reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mariocj89
Fix when parsing tz offsets microseconds shorter than 6
4abf793 
As the remainder is directly parsed as an int, strings like
.600 will be parsed as 600 microsecond rather than miliseconds.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 10, 2017
@bedevere-bot bedevere-bot added the awaiting review label Dec 10, 2017
@mariocj89 mariocj89 changed the title Fix when parsing tz offsets microseconds shorter than 6 bpo-32267: Fix when parsing tz offsets microseconds shorter than 6 Dec 10, 2017
@mariocj89 mariocj89 changed the title bpo-32267: Fix when parsing tz offsets microseconds shorter than 6 bpo-32267: Fix parsing tz offsets microseconds shorter than 6 Dec 10, 2017
pganssle
pganssle reviewed Dec 13, 2017
View reviewed changes
Comment thread Lib/_strptime.py
gmtoff_fraction = int(z[8:] or 0)
gmtoff_remainder = z[8:]
# Pad to always return microseconds.
gmtoff_remainder_padding = "0" * (6 - len(gmtoff_remainder))

@pganssle pganssle Dec 13, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a microbenchmark for this vs. multiplying by 10**(6-len(gmtoff_remainder)) and it seems like your version is either faster or the same speed. Maybe that's why you chose this method, but I thought I'd chime in since I went through the trouble to check it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
mariocj89 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mariocj89

mariocj89 commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

@abalkin sorry to mention you but without this change the previous PR change is buggy.
Mentioning as probably as the commit status is failed it will fall off the radar. If you want I can create a news entry but I think it makes no sense
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pganssle

pganssle commented Jan 4, 2018

Copy link
Copy Markdown
Member

FWIW this patch looks good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abalkin abalkin self-assigned this Jan 9, 2018
@abalkin abalkin added the skip news label Jan 9, 2018
abalkin
abalkin approved these changes Jan 9, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jan 9, 2018
@abalkin
abalkin merged commit f80c0ca into python:master Jan 9, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jan 9, 2018
@mariocj89

mariocj89 commented Jan 9, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mariocj89
mariocj89 deleted the fix_strptime_us_isoparse branch September 14, 2019 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle left review comments
@abalkin abalkin abalkin approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@abalkin abalkin

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@mariocj89 @pganssle @abalkin @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.