GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-27456: Simplify sock type checks by 1st1 · Pull Request #4922 · python/cpython

Conversation

@1st1

@1st1 1st1 commented Dec 19, 2017 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Recent sock.type fix (see bug 32331) makes sock.type checks simpler
in asyncio.

https://bugs.python.org/issue27456

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Yury Selivanov
bpo-27456: Simplify sock type checks
1da4cbe 
Recent sock.type fix (see bug 32331) makes sock.type checks simpler
in asyncio.
@1st1 1st1 added the skip news label Dec 19, 2017
@1st1
1st1 requested a review from asvetlov as a code owner December 19, 2017 01:32
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Dec 19, 2017
@bedevere-bot bedevere-bot added the awaiting merge label Dec 19, 2017
asvetlov
asvetlov approved these changes Dec 19, 2017
View reviewed changes
@1st1
1st1 merged commit a7bd64c into python:master Dec 19, 2017
@bedevere-bot bedevere-bot removed the awaiting merge label Dec 19, 2017
@1st1
1st1 deleted the aio_sock_type branch December 19, 2017 11:44
@tjhowse tjhowse mentioned this pull request Feb 2, 2024
create_datagram_endpoint() no longer compatible with CAN bus raw sockets #114887
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@1st1 @asvetlov @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.