GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-29248: Fix os.readlink() on Windows (GH-5577) by miss-islington · Pull Request #5640 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 12, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.
(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 [email protected]

https://bugs.python.org/issue29248

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@SSE4 @miss-islington
bpo-29248: Fix os.readlink() on Windows (pythonGH-5577)
1dfe7a7 
The PrintNameOffset field of the reparse data buffer
was treated as a number of characters instead of bytes.
(cherry picked from commit 3c34aad)

Co-authored-by: SSE4 <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Feb 12, 2018
bpo-29248: Fix readlink bug os #5577
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 12, 2018
@bedevere-bot bedevere-bot added the awaiting review label Feb 12, 2018
@miss-islington

miss-islington commented Feb 12, 2018

Copy link
Copy Markdown
Contributor Author

@SSE4 and @berkerpeksag: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@berkerpeksag
berkerpeksag merged commit a1d33f7 into python:3.6 Feb 12, 2018
@miss-islington

miss-islington commented Feb 12, 2018

Copy link
Copy Markdown
Contributor Author

Thanks, @berkerpeksag!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Feb 12, 2018
@miss-islington
miss-islington deleted the backport-3c34aad-3.6 branch February 12, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @berkerpeksag @the-knights-who-say-ni @bedevere-bot @SSE4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.