GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-30028: make test.support.temp_cwd() fork-safe (GH-1066) by miss-islington · Pull Request #5824 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 23, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Make test.support.temp_cwd() fork-safe. The context manager test.support.temp_cwd() no longer removes the temporary directory when executing in a process other than the parent it entered from.
If a forked child exits the context manager it won't do the cleanup.
(cherry picked from commit 33dddac)

Co-authored-by: Anselm Kruis [email protected]

https://bugs.python.org/issue30028

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Anselm Kruis @miss-islington
bpo-30028: make test.support.temp_cwd() fork-safe (pythonGH-1066)
357ce94
Make test.support.temp_cwd() fork-safe. The context manager test.support.temp_cwd() no longer removes the temporary directory when executing in a process other than the parent it entered from.
If a forked child exits the context manager it won't do the cleanup.
(cherry picked from commit 33dddac)

Co-authored-by: Anselm Kruis <[email protected]>
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir labels Feb 23, 2018
@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2018
bpo-30028: make test.support.temp_cwd() fork-safe #1066
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 23, 2018
@bedevere-bot bedevere-bot added the awaiting review label Feb 23, 2018
@miss-islington

miss-islington commented Feb 23, 2018

Copy link
Copy Markdown
Contributor Author

@akruis and @gpshead: Backport status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead
gpshead approved these changes Feb 23, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 23, 2018
@miss-islington
miss-islington merged commit 694c5e0 into python:3.7 Feb 23, 2018
@miss-islington

miss-islington commented Feb 23, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Feb 23, 2018
@miss-islington
miss-islington deleted the backport-33dddac-3.7 branch February 23, 2018 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gpshead @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.