GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-24132: refactor pathlib to allow easy subclassing by ypsah · Pull Request #6248 · python/cpython

Conversation

@ypsah

@ypsah ypsah commented Mar 26, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

PurePath and Path are now just variables pointing at the
corresponding classes (resp. PurePosixPath or PureWindowsPath, and
PosixPath or WindowsPath) depending on the platform running the code.

https://bugs.python.org/issue24132

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni

the-knights-who-say-ni commented Mar 26, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Mar 26, 2018
@bedevere-bot bedevere-bot added the awaiting review label Mar 26, 2018
@ypsah
ypsah force-pushed the master branch from e46fed8 to 478aa25 Compare March 27, 2018 23:36
@ypsah
bpo-24132: refactor pathlib to allow easy subclassing
2529dad 
`PurePath` and `Path` are now just variables pointing at the
corresponding classes (resp. PurePosixPath or PureWindowsPath, and
PosixPath or WindowsPath) depending on the platform running the code.
@ypsah
ypsah force-pushed the master branch from 478aa25 to 2529dad Compare March 27, 2018 23:50
@brettcannon brettcannon removed the CLA not signed label Mar 26, 2019
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Mar 26, 2019
@brettcannon

brettcannon commented Mar 26, 2019

Copy link
Copy Markdown
Member

Thanks for the PR, but closing as the CLA has not been signed within the last month. If you do decide to sign the CLA we can re-open this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brettcannon brettcannon closed this Mar 26, 2019
gst
gst reviewed Mar 26, 2021
View reviewed changes
Comment thread Lib/pathlib.py
class _PathParents(Sequence):
"""This object provides sesquence-like access to the logical ancestors
of a path. Don't try to construt it yourself."""
___slots__ = ('pathcls', '_drv', '_root', '_parts')

@gst gst Mar 26, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably a typo but you have 3 leading _ ..

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@projetmbc projetmbc mannequin mentioned this pull request Jun 21, 2022
Direct sub-classing of pathlib.Path #68320
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gst gst gst left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ypsah @the-knights-who-say-ni @brettcannon @gst @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.