GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-33767: Fix improper use of SystemError by mmap.mmap objects (GH-7381) by miss-islington · Pull Request #7426 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 5, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Raise TypeError instead of SystemError for unsupported operations.
(cherry picked from commit e9e3976)

Co-authored-by: Zackery Spytz [email protected]

https://bugs.python.org/issue33767

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZackerySpytz @miss-islington
bpo-33767: Fix improper use of SystemError by mmap.mmap objects (pyth…
ca7bc83 
…onGH-7381)

Raise TypeError instead of SystemError for unsupported operations.
(cherry picked from commit e9e3976)

Co-authored-by: Zackery Spytz <[email protected]>
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 5, 2018
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Jun 5, 2018
@bedevere-bot bedevere-bot mentioned this pull request Jun 5, 2018
bpo-33767: Fix improper use of SystemError by mmap.mmap objects #7381
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jun 5, 2018
@miss-islington

miss-islington commented Jun 5, 2018

Copy link
Copy Markdown
Contributor Author

@ZackerySpytz and @serhiy-storchaka: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Jun 5, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 5, 2018
@miss-islington
miss-islington merged commit 631fe1f into python:3.7 Jun 5, 2018
@miss-islington

miss-islington commented Jun 5, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 5, 2018
@miss-islington
miss-islington deleted the backport-e9e3976-3.7 branch June 5, 2018 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot @ZackerySpytz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.