GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.6] bpo-11874: fix assertion failure in argparse metavar handling (GH-1826) by miss-islington · Pull Request #7528 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 8, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • bugfix and test for fragile metavar handling in argparse (see
    bpo-24089, bpo-14046, bpo-25058, bpo-11874)
  • also fixes some incorrect tests that did not make 1-element tuples correctly
    (cherry picked from commit 66f02aa)

Co-authored-by: wim glenn [email protected]

https://bugs.python.org/issue11874

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wimglenn @miss-islington
bpo-11874: fix assertion failure in argparse metavar handling (python…
6967101 
…GH-1826)

- bugfix and test for fragile metavar handling in argparse (see
  bpo-24089, bpo-14046, bpo-25058, bpo-11874)
- also fixes some incorrect tests that did not make 1-element tuples correctly
(cherry picked from commit 66f02aa)

Co-authored-by: wim glenn <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jun 8, 2018
bpo-11874 argparse assertion failure #1826
Merged
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 8, 2018
@bedevere-bot bedevere-bot added the awaiting review label Jun 8, 2018
@miss-islington

miss-islington commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

@wimglenn and @ncoghlan: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ncoghlan
ncoghlan approved these changes Jun 8, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 8, 2018
@miss-islington
miss-islington merged commit 376c272 into python:3.6 Jun 8, 2018
@miss-islington

miss-islington commented Jun 8, 2018

Copy link
Copy Markdown
Contributor Author

Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 8, 2018
@miss-islington
miss-islington deleted the backport-66f02aa-3.6 branch June 8, 2018 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ncoghlan ncoghlan ncoghlan approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @ncoghlan @the-knights-who-say-ni @bedevere-bot @wimglenn
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.