GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-19930: The mode argument of os.makedirs() no longer affects the file by serhiy-storchaka · Pull Request #799 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Mar 24, 2017

Copy link
Copy Markdown
Member

permission bits of newly-created intermediate-level directories.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-19930: The mode argument of os.makedirs() no longer affects the file
b0ba886 
permission bits of newly-created intermediate-level directories.
@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Mar 24, 2017
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Mar 24, 2017
@mention-bot

mention-bot commented Mar 24, 2017

Copy link
Copy Markdown

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @benjaminp and @larryhastings to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Mar 24, 2017
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does the test pass on Windows?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner

vstinner commented Mar 24, 2017

Copy link
Copy Markdown
Member

I'm now working on http://bugs.python.org/issue29530 First, I would like to repair Windows buildbots :-p (currently failing)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Mar 24, 2017

Copy link
Copy Markdown
Member Author

At least the AppVeyor build succeeded.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit e304e33 into python:master Mar 24, 2017
@serhiy-storchaka
serhiy-storchaka deleted the os-makedirs-mode branch March 24, 2017 11:27
@rdb rdb mentioned this pull request Jan 23, 2019
Permissions on /usr/lib64/python3.x/site-packages directory in .rpm panda3d/panda3d#541
Closed
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 10, 2022
os.makedirs('dir1/dir2', 0) always fails #64129
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @mention-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.